[
https://issues.apache.org/jira/browse/PDFBOX-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792798#comment-17792798
]
Axel Howind commented on PDFBOX-5725:
-------------------------------------
Added patch "coding_convention,_use_switch.patch".
This patch fixes some formatting to use the PdfBox coding conventions and
replaces if..else if...else with a switch.
> CharStringCommand overly complex
> --------------------------------
>
> Key: PDFBOX-5725
> URL: https://issues.apache.org/jira/browse/PDFBOX-5725
> Project: PDFBox
> Issue Type: Improvement
> Reporter: Axel Howind
> Priority: Minor
> Attachments: coding_convention,_use_switch.patch,
> refactor_CharStringCommand.patch
>
>
> The CharStringCommand class is quite complex and difficult to understand what
> it does in detail. I suggest a refactoring to make the code shorter and
> easier to understand. It should also perform better after the refactoring.
> I have prepared a patch that
> * turns CharStringCommand into an enum
> * removes the internal Key class
> * removes the different maps used for lookup and replaces them with a single
> array for faster lookup
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
