[ https://issues.apache.org/jira/browse/PDFBOX-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803476#comment-17803476 ]
Axel Howind commented on PDFBOX-5731: ------------------------------------- [~msahyoun] No, it would not have any benefit. The COSNames behave like value objects. If we bind them to the PDDocument, we would need more heap if we have instances with the same name in multiple PDDocument instances. Maybe you think if we bind them to the PDDocument they could simply be cleared once the document is GCed. But that's the same that happens now: once GC runs, all unused instances will be automatically GCed. IMHO such a binding would only introduce overhead. > org.apache.pdfbox.cos.COSName#nameMap There is a memory leak problem. > --------------------------------------------------------------------- > > Key: PDFBOX-5731 > URL: https://issues.apache.org/jira/browse/PDFBOX-5731 > Project: PDFBox > Issue Type: Bug > Affects Versions: 2.0.30, 3.0.1 PDFBox > Reporter: liu > Assignee: Andreas Lehmkühler > Priority: Major > Fix For: 4.0.0 > > Attachments: COSName.java, > PDFBOX-5731_clear_out_unused_COSName_instances_automatically_PDFBOX2.patch, > PDFBox5731_clear_out_unused_COSName_instances_automatically_PDFBOX3.patch, > attempted_fix_for_PDFBOX-5731__clear_out_unused_COSName_instances_automatically.patch, > > attempted_fix_for_PDFBOX-5731__clear_out_unused_COSName_instances_automatically_2.patch, > > attempted_fix_for_PDFBOX-5731__clear_out_unused_COSName_instances_automatically_using_cleaner.patch, > image-2023-12-08-16-02-12-293.png, image-2023-12-13-17-04-22-073.png, > image-2023-12-14-18-10-14-278.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png, > screenshot-8.png > > > !image-2023-12-08-16-02-12-293.png! > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org