lehmi commented on code in PR #188:
URL: https://github.com/apache/pdfbox/pull/188#discussion_r1546231761
##########
fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java:
##########
@@ -161,15 +159,15 @@ private void render()
});
}
- private List<Number> handleType1Command(List<Number> numbers,
CharStringCommand command)
+ private void handleType1Command(List<Number> numbers, CharStringCommand
command)
{
commandCount++;
Type1KeyWord type1KeyWord = command.getType1KeyWord();
if (type1KeyWord == null)
{
// indicates an invalid charstring
LOG.warn("Unknown charstring command in glyph {} of font {}",
glyphName, fontName);
- return Collections.emptyList();
+ numbers.clear();
Review Comment:
The immediate return is missing, so that the switch runs into the default
case and throws an exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
