[ 
https://issues.apache.org/jira/browse/PDFBOX-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902117#comment-17902117
 ] 

Tilman Hausherr edited comment on PDFBOX-5915 at 12/1/24 5:36 PM:
------------------------------------------------------------------

In 2.0 the whole byte array is kept in the charstring object, in 
{{Key.keyvalues}}, in 3.0 it is lost. If we ever implement the missing 
commands, then the data would "almost" be there, only the TODO would have to be 
implemented to have the mask data. Coincidentally, my first idea was to 
implement what you mentioned in the last line of your comment. I dropped that 
because I thought that it would be better to have everything except the part 
that needs to be implemented, i.e. storing the extra mask data in the 
charstring object. I didn't do that because I thought that until somebody 
implements the actual handling of hintmask and cntrmask, there is no need to 
have an extra field that takes memory space.


was (Author: tilman):
In 2.0 the whole byte array was kept in the charstring object, in 
{{Key.keyvalues}}. If we ever implement the missing commands, then the data 
would "almost" be there, only the TODO would have to be implemented to have the 
mask data. Coincidentally, my first idea was to implement what you mentioned in 
the last line of your comment. I dropped that because I thought that it would 
be better to have everything except the part that needs to be implemented, i.e. 
storing the extra mask data in the charstring object. I didn't do that because 
I thought that until somebody implements the actual handling of hintmask and 
cntrmask, there is no need to have an extra field that takes memory space.

> false "Unknown charstring command in glyph" messages
> ----------------------------------------------------
>
>                 Key: PDFBOX-5915
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5915
>             Project: PDFBox
>          Issue Type: Bug
>          Components: FontBox
>    Affects Versions: 3.0.3 PDFBox
>            Reporter: Tilman Hausherr
>            Assignee: Tilman Hausherr
>            Priority: Minor
>             Fix For: 3.0.4 PDFBox, 4.0.0
>
>
> I'm often getting "Unknown charstring command in glyph" messages. I took the 
> time to find whether these are real, and they're not. They happen because of 
> type2 charstrings that start with 19 or 20. These are passed to 
> {{CharStringCommand.getInstance(value)}} where they are classified as UNKNOWN 
> either because the value array is more than 2 or because a 2 byte command 
> doesn't result in a known value. However 19 and 20 are 1 byte commands 
> (hintmask and cntrmask, which we ignore) so this must be changed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to