[
https://issues.apache.org/jira/browse/PDFBOX-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924858#comment-17924858
]
ASF subversion and git services commented on PDFBOX-974:
--------------------------------------------------------
Commit 1923640 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1923640 ]
PDFBOX-974: make printer name match case insensitive, as suggested by
Christophe Borivant
> PrintPDF should not be case sensitive against printer name on Windows
> ---------------------------------------------------------------------
>
> Key: PDFBOX-974
> URL: https://issues.apache.org/jira/browse/PDFBOX-974
> Project: PDFBox
> Issue Type: Wish
> Components: Utilities
> Affects Versions: 1.5.0
> Environment: Windows XP/ JRE 1.6.0_24
> Reporter: Christophe Borivant
> Priority: Minor
>
> Microsoft Os are mostly case insensitive.
> If a printerName is given to PrintPDF, it looks for the provided string in a
> case sensitive manner ( line around 115 ).
> I made a little correction to the code to allow non case sensitive search on
> Windows os :
> I changed :
> {code}
> if(printService[i].getName().indexOf(printerName) != -1)
> {
> printJob.setPrintService(printService[i]);
> printerFound = true;
> }
> {code}
> to :
> {code}
> if (isWindows())
> {
>
> if(printService[i].getName().toLowerCase().indexOf(printerName.toLowerCase())
> != -1)
> {
> printJob.setPrintService(printService[i]);
> printerFound = true;
> }
> }
> else
> {
> if(printService[i].getName().indexOf(printerName) != -1)
> {
> printJob.setPrintService(printService[i]);
> printerFound = true;
> }
> }
> {code}
> and added the method :
> {code}
> public static boolean isWindows()
> {
> String os = System.getProperty("os.name").toLowerCase();
> return (os.indexOf( "win" ) >= 0);
> }
> {code}
> I'm not sure it's the best way to do it, but at least, it works !
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
