gredler opened a new pull request, #202: URL: https://github.com/apache/pdfbox/pull/202
- Add missing JavaDoc - Simplify a few variable names, in some cases allowing wrapped lines to fit on one line - Avoid unnecessary extra cast - Pre-size ByteArrayOutputStream to size which should usually be enough to fit all encoded glyphs - Remove unnecessary special cases from word loop - Avoid need to throw IOExceptions by using ByteArrayOutputStream-specific writeBytes method - Avoid unnecessary codePointCount( ) call to get number of code points - Simplify IllegalStateException error message to match similar messages elsewhere in the codebase Happy to tweak the changes, if they look mostly good but there are one or two things that need to be done differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
