THausherr commented on PR #255: URL: https://github.com/apache/pdfbox/pull/255#issuecomment-3315058373
I think the proposed patch would be rather for 3.0 and 2.0 to preserve compatibility, while an ideal patch for the trunk would have an abstract method for `visitFromObject` and your proposed "default" code would go into a method in `COSWriter`, do you agree or disagree? (You don't have to change the patch, I'd adjust it if you agree with my understanding) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
