valerybokov commented on code in PR #287: URL: https://github.com/apache/pdfbox/pull/287#discussion_r2423114132
########## io/src/main/java/org/apache/pdfbox/io/RandomAccessReadMemoryMappedFile.java: ########## @@ -110,6 +110,7 @@ public void close() throws IOException if (fileChannel != null) { fileChannel.close(); + fileChannel = null; Review Comment: The idea isn't to nullify references, but to avoid calling the close method multiple times, since it's often synchronized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org