lehmi commented on PR #383: URL: https://github.com/apache/pdfbox/pull/383#issuecomment-3691402220
How could you be so sure that you checked all cases? I had a quick look and there are different branches which get confusing there one dig deeper into it. Many of them ended in java.net.URLConnection.getInputStream() which is implemented by several classes and some are JDK specific, so that there might be other implementations in other JDK you never saw. I've found one example in the corretto JDK which uses an ByteArrayInput stream: sun.net.www.protocol.file.FileURLConnection.getInputStream() I'm afraid the assumption that all implementations are already returning a buffered stream is not correct. I agree with @THausherr and won't support a check. Did you have some cases where such a change introduces a real improvement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
