zhangyifan27 opened a new pull request #587:
URL: https://github.com/apache/incubator-pegasus/pull/587


   ### What problem does this PR solve? <!--add issue link with summary if 
exists-->
   
   #571 
   
   ### What is changed and how it works?
   
   RocksDB database will automatically persist its current set of options into 
a file since RocksDB 4.3[1], 
   so when DB exit, we should reopen the rocksdb instance using the options 
file stored in the db directory.
   
   If store usage scenario into meta column family, we need to open DB with 
default options and then read
   meta data and set options, that would also lead to unexpected flushs and 
compactions.
   
   [1] https://github.com/facebook/rocksdb/wiki/RocksDB-Options-File
   
   ### Check List <!--REMOVE the items that are not applicable-->
   
   Tests <!-- At least one of them must be included. -->
   
   - Unit test
   - Integration test
   
   Code changes
   
   - Has exported function/method change
   
   Side effects
   
   - Increased code complexity
   
   Related changes
   
   - Need to cherry-pick to the release branch
   - Need to be included in the release note
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to