Smityz commented on a change in pull request #592:
URL: https://github.com/apache/incubator-pegasus/pull/592#discussion_r487758788
##########
File path: src/server/hotspot_partition_calculator.h
##########
@@ -17,13 +17,20 @@
#pragma once
-#include "hotspot_partition_data.h"
+#include "hotspot_partition_stat.h"
#include <gtest/gtest_prod.h>
#include <dsn/perf_counter/perf_counter.h>
namespace pegasus {
namespace server {
+// stores the whole histories of all partitions in one table
+typedef std::list<std::vector<hotspot_partition_stat>> stat_histories;
+// hot_partition_counters c[index_of_partitions][type_of_read(0)/write(1)_stat]
+// so if we have n partitions, we will get 2*n hot_partition_counters, to
demonstrate both
+// read/write hotspot value
+typedef std::vector<std::vector<std::unique_ptr<dsn::perf_counter_wrapper>>>
hot_partition_counters;
Review comment:
```cpp
class perf_counter_wrapper
{
public:
perf_counter_wrapper() { _counter = nullptr; }
perf_counter_wrapper(const perf_counter_wrapper &other) = delete;
perf_counter_wrapper(perf_counter_wrapper &other) = delete;
perf_counter_wrapper(perf_counter_wrapper &&other) = delete;
perf_counter_wrapper &operator=(const perf_counter_wrapper &other) =
delete;
perf_counter_wrapper &operator=(perf_counter_wrapper &other) = delete;
perf_counter_wrapper &operator=(perf_counter_wrapper &&other) = delete;
```
It is hard to construct perf_counter_wrapper without unique_ptr in vector
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
