hycdong commented on a change in pull request #598:
URL: https://github.com/apache/incubator-pegasus/pull/598#discussion_r488413553
##########
File path: src/server/pegasus_write_service_impl.h
##########
@@ -675,7 +664,7 @@ class pegasus_write_service::impl : public
dsn::replication::replica_base
return status.code();
}
- // The resulted `expire_ts` is -1 if record is expired.
+ /// \returns 0 if success.
Review comment:
I think the comment of this function should be more detailed, such as
the expired case, not_found case, these case will also return 0, but in my
view, they are not simply success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
