acelyc111 commented on a change in pull request #604:
URL: https://github.com/apache/incubator-pegasus/pull/604#discussion_r490769141
##########
File path: src/server/hotspot_partition_calculator.cpp
##########
@@ -42,6 +43,24 @@ DSN_DEFINE_int64("pegasus.collector",
"eliminate outdated historical "
"data");
+DSN_DEFINE_bool("pegasus.collector",
+ enable_hotkey_auto_detect,
+ false,
+ "auto detect hot key in the hot paritition");
+
+DSN_DEFINE_int32("pegasus.collector",
+ hot_partition_threshold,
+ 3,
+ "threshold of hotspot partition value,if
hot_partition_counter >= "
+ "FLAGS_hotpartition_threshold, This partition is a hot
partition");
+
+DSN_DEFINE_int32("pegasus.collector",
+ occurrence_threshold,
+ 100,
+ "hot paritiotion occurrence times'threshold to send rpc to
detect hotkey,if one "
Review comment:
```suggestion
"hot paritiotion occurrence times' threshold to send rpc to
detect hotkey, if one "
```
##########
File path: src/server/hotspot_partition_calculator.cpp
##########
@@ -42,6 +43,24 @@ DSN_DEFINE_int64("pegasus.collector",
"eliminate outdated historical "
"data");
+DSN_DEFINE_bool("pegasus.collector",
+ enable_hotkey_auto_detect,
+ false,
+ "auto detect hot key in the hot paritition");
+
+DSN_DEFINE_int32("pegasus.collector",
+ hot_partition_threshold,
+ 3,
+ "threshold of hotspot partition value,if
hot_partition_counter >= "
Review comment:
User don't know what `hot_partition_counter ` is.
##########
File path: src/server/hotspot_partition_calculator.cpp
##########
@@ -42,6 +43,24 @@ DSN_DEFINE_int64("pegasus.collector",
"eliminate outdated historical "
"data");
+DSN_DEFINE_bool("pegasus.collector",
+ enable_hotkey_auto_detect,
+ false,
+ "auto detect hot key in the hot paritition");
+
+DSN_DEFINE_int32("pegasus.collector",
+ hot_partition_threshold,
+ 3,
+ "threshold of hotspot partition value,if
hot_partition_counter >= "
+ "FLAGS_hotpartition_threshold, This partition is a hot
partition");
+
+DSN_DEFINE_int32("pegasus.collector",
+ occurrence_threshold,
+ 100,
+ "hot paritiotion occurrence times'threshold to send rpc to
detect hotkey,if one "
+ "partition's _over_threshold_times_read/write >=
FLAGS_occurrence_threshold "
Review comment:
These comments will be exposed to common users, so these internal
variables should not appear here.
##########
File path: src/server/hotspot_partition_calculator.cpp
##########
@@ -42,6 +43,24 @@ DSN_DEFINE_int64("pegasus.collector",
"eliminate outdated historical "
"data");
+DSN_DEFINE_bool("pegasus.collector",
+ enable_hotkey_auto_detect,
+ false,
+ "auto detect hot key in the hot paritition");
+
+DSN_DEFINE_int32("pegasus.collector",
+ hot_partition_threshold,
+ 3,
+ "threshold of hotspot partition value,if
hot_partition_counter >= "
Review comment:
```suggestion
"threshold of hotspot partition value, if
hot_partition_counter >= "
```
##########
File path: src/server/test/config.ini
##########
@@ -509,3 +509,6 @@ onebox2 = 2
[pegasus.clusters]
onebox = 0.0.0.0:34701
onebox2 = 0.0.0.0:35701
+
+[pegasus.collector]
+enable_hotkey_auto_detect = true
Review comment:
```suggestion
enable_hotkey_detect = true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
