hycdong commented on a change in pull request #665:
URL: https://github.com/apache/incubator-pegasus/pull/665#discussion_r551687218
##########
File path: src/server/hotkey_collector.cpp
##########
@@ -265,6 +265,8 @@ void
hotkey_collector::on_start_detect(dsn::replication::detect_hotkey_response
derror_replica(hint);
dassert(false, "invalid collector state");
}
+ resp.__set_err_hint(hint);
+ dwarn_replica(hint);
Review comment:
L268-L269 won't be executed, because it will either return or assert
before it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
