levy5307 opened a new pull request #670:
URL: https://github.com/apache/incubator-pegasus/pull/670
### What problem does this PR solve? <!--add issue link with summary if
exists-->
use rocksdb_wrapper to reimplement `empty_put`
### Check List <!--REMOVE the items that are not applicable-->
Tests <!-- At least one of them must be included. -->
- Unit test
There are some unit tests in `pegasus_write_service_test.cpp` to test
`empty_put`
- Manual test (add detailed scripts or steps below)
Use incr to trigger empty_put
```
>>> use temp
OK
>>> set a b c
OK
app_id : 2
partition_index : 4
decree : 1
server : 10.232.55.210:34802
>>> incr a b 1
ERROR: invalid argument
app_id : 2
partition_index : 4
decree : 2
server : 10.232.55.210:34802
>>> incr a b 1
ERROR: invalid argument
app_id : 2
partition_index : 4
decree : 3
server : 10.232.55.210:34802
>>> incr a b 5
ERROR: invalid argument
app_id : 2
partition_index : 4
decree : 5
server : 10.232.55.210:34802
```
Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
