levy5307 commented on a change in pull request #679:
URL: https://github.com/apache/incubator-pegasus/pull/679#discussion_r555485727
##########
File path: src/server/hotkey_collector.cpp
##########
@@ -33,12 +33,18 @@ DSN_DEFINE_uint32(
hot_bucket_variance_threshold,
7,
"the variance threshold to detect hot bucket during coarse analysis of
hotkey detection");
+DSN_TAG_VARIABLE(hot_bucket_variance_threshold, FT_MUTABLE);
+DSN_DEFINE_validator(hot_bucket_variance_threshold,
Review comment:
uint32 must be >= 0, I think it's useless to add a validator here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
