neverchanje commented on a change in pull request #688:
URL: https://github.com/apache/incubator-pegasus/pull/688#discussion_r566818037
##########
File path: src/server/key_ttl_compaction_filter.h
##########
@@ -58,7 +84,13 @@ class KeyWithTTLCompactionFilter : public
rocksdb::CompactionFilter
*value_changed = true;
return false;
}
- return check_if_ts_expired(utils::epoch_now(), expire_ts);
+
+ uint32_t now_ts = utils::epoch_now();
+ if (check_if_ts_expired(now_ts, expire_ts)) {
+ return true;
+ }
+
+ return need_clean_key(key, expire_ts, now_ts);
Review comment:
可以不加，compaction filter拿不到appid，想拿到appid需要增加额外代码
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
