hycdong commented on a change in pull request #683: URL: https://github.com/apache/incubator-pegasus/pull/683#discussion_r567536866
########## File path: src/server/table_stats.h ########## @@ -1,187 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -#pragma once - -struct table_stats -{ - table_stats(const std::string &app_name) : app_name(app_name) {} - - double get_total_read_qps() const - { - return total_get_qps + total_multi_get_qps + total_scan_qps; - } - - double get_total_write_qps() const - { - return total_put_qps + total_multi_put_qps + total_remove_qps + total_multi_remove_qps + - total_incr_qps + total_check_and_set_qps + total_check_and_mutate_qps + - total_duplicate_qps; - } - - double get_total_read_bytes() const - { - return total_get_bytes + total_multi_get_bytes + total_scan_bytes; - } - - double get_total_write_bytes() const - { - return total_put_bytes + total_multi_put_bytes + total_check_and_set_bytes + - total_check_and_mutate_bytes; - } - - void aggregate(const row_data &row) - { - total_get_qps += row.get_qps; - total_multi_get_qps += row.multi_get_qps; - total_put_qps += row.put_qps; - total_multi_put_qps += row.multi_put_qps; - total_remove_qps += row.remove_qps; - total_multi_remove_qps += row.multi_remove_qps; - total_incr_qps += row.incr_qps; - total_check_and_set_qps += row.check_and_set_qps; - total_check_and_mutate_qps += row.check_and_mutate_qps; - total_scan_qps += row.scan_qps; - total_duplicate_qps += row.duplicate_qps; - total_dup_shipped_ops += row.dup_shipped_ops; - total_dup_failed_shipping_ops += row.dup_failed_shipping_ops; - total_recent_read_cu += row.recent_read_cu; - total_recent_write_cu += row.recent_write_cu; - total_recent_expire_count += row.recent_expire_count; - total_recent_filter_count += row.recent_filter_count; - total_recent_abnormal_count += row.recent_abnormal_count; - total_recent_write_throttling_delay_count += row.recent_write_throttling_delay_count; - total_recent_write_throttling_reject_count += row.recent_write_throttling_reject_count; - total_storage_mb += row.storage_mb; - total_storage_count += row.storage_count; - total_rdb_block_cache_hit_count += row.rdb_block_cache_hit_count; - total_rdb_block_cache_total_count += row.rdb_block_cache_total_count; - total_rdb_index_and_filter_blocks_mem_usage += row.rdb_index_and_filter_blocks_mem_usage; - total_rdb_memtable_mem_usage += row.rdb_memtable_mem_usage; - total_rdb_estimate_num_keys += row.rdb_estimate_num_keys; - total_rdb_bf_seek_negatives += row.rdb_bf_seek_negatives; - total_rdb_bf_seek_total += row.rdb_bf_seek_total; - total_rdb_bf_point_positive_true += row.rdb_bf_point_positive_true; - total_rdb_bf_point_positive_total += row.rdb_bf_point_positive_total; - total_rdb_bf_point_negatives += row.rdb_bf_point_negatives; - total_backup_request_qps += row.backup_request_qps; - total_get_bytes += row.get_bytes; - total_multi_get_bytes += row.multi_get_bytes; - total_scan_bytes += row.scan_bytes; - total_put_bytes += row.put_bytes; - total_multi_put_bytes += row.multi_put_bytes; - total_check_and_set_bytes += row.check_and_set_bytes; - total_check_and_mutate_bytes += row.check_and_mutate_bytes; - } - - void merge(const table_stats &row_stats) Review comment: Could you please explain difference between function `aggeragate` and `merge` to me? I noticed that you use `aggerate` replace `merge` in info_collector.cpp. ########## File path: src/server/table_stats.h ########## @@ -1,187 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -#pragma once - -struct table_stats -{ - table_stats(const std::string &app_name) : app_name(app_name) {} - - double get_total_read_qps() const - { - return total_get_qps + total_multi_get_qps + total_scan_qps; - } - - double get_total_write_qps() const Review comment: Function `get_total_write_qps` in `command_helper.h` doesn't add incr and duplicate qps ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
