neverchanje commented on a change in pull request #684:
URL: https://github.com/apache/incubator-pegasus/pull/684#discussion_r567562233
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -1802,19 +1802,21 @@ ::dsn::error_code
pegasus_server_impl::async_checkpoint(bool flush_memtable)
// Must be thread safe.
::dsn::error_code pegasus_server_impl::copy_checkpoint_to_dir(const char
*checkpoint_dir,
- /*output*/
int64_t *last_decree)
+ /*output*/
int64_t *last_decree,
+ bool
flush_memtable)
Review comment:
Usually argument is before output variables.
`copy_checkpoint_to_dir(const char *checkpoint_dir, const bool flush_memtable,
/*output*/ int64_t last_decree)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
