neverchanje opened a new pull request #700:
URL: https://github.com/apache/incubator-pegasus/pull/700


   ### What problem does this PR solve? <!--add issue link with summary if 
exists-->
   
   Some environments may build pegasus with less dependencies than we expected. 
For example, we assume that ubuntu18.04 must require icui18n icuuc icudata, but 
with image 
[pegasus-kv/thirdparties-bin:ubuntu1804](https://github.com/orgs/pegasus-kv/packages/container/thirdparties-bin/1553681)
 I found it always builds without linking these libs. So when we package 
pegasus, the script will fail if it can't find them in the system path (apt 
doesn't find this package). This is annoying and needs endless fixes.
   
   ### What is changed and how it works?
   
   I add a check before packaging a lib, if it's not required, the script 
prints an error log and goes on.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to