Shuo-Jia opened a new pull request #718: URL: https://github.com/apache/incubator-pegasus/pull/718
### What problem does this PR solve? <!--add issue link with summary if exists--> #533 overload `dump_write_request` for https://github.com/XiaoMi/rdsn/pull/414 and cause the problem that the server will auto-reply to client with `ERR_OK`, so all the `response_client_write` after `dump_write_request` will be ignored for client, it also mean client will receive `ERR_OK`, though pass `ERR_INVALID_DATA` in https://github.com/XiaoMi/rdsn/pull/414. ### What is changed and how does it work? This PR use rpc_holder constructor replace `rpc::auto_replay`to dump request ### Checklist <!--REMOVE the items that are not applicable--> - Manual test (add detailed scripts or steps below) ##### Side effects - large write request will be responsed with `ERR_INVALID_DATA` and throw exception at client side ##### Related changes - Need to cherry-pick to the release branch - Need to update the documentation - Need to be included in the release note -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org For additional commands, e-mail: dev-h...@pegasus.apache.org
