cauchy1988 commented on a change in pull request #897:
URL: https://github.com/apache/incubator-pegasus/pull/897#discussion_r802297066
##########
File path: src/server/pegasus_server_impl.h
##########
@@ -382,6 +398,8 @@ class pegasus_server_impl : public pegasus_read_service
uint64_t _abnormal_get_size_threshold;
uint64_t _abnormal_multi_get_size_threshold;
uint64_t _abnormal_multi_get_iterate_count_threshold;
+ uint64_t _abnormal_batch_get_size_threshold;
Review comment:
(1)where to change the `gflag`? I’m not sure what you said;
(2)I have considered supporting `auto-update`, but gave up finally and
consequently let these two added `threshold` just behave in consistent with
`_abnormal_multi_get_size_threshold` or
`_abnormal_multi_get_iterate_count_threshold`;
we will change these two `threshold` through config-file only;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]