WHBANG commented on code in PR #1019:
URL: https://github.com/apache/incubator-pegasus/pull/1019#discussion_r907295907
##########
java-client/src/main/java/org/apache/pegasus/client/PegasusScanner.java:
##########
@@ -88,9 +88,31 @@ public PegasusScanner(
_needCheckHash = needCheckHash;
_incomplete = false;
_fullScan = fullScan;
+ _nextItem = null;
+ }
+
+ public boolean hasNext() throws PException {
+ synchronized (_nextItemLock) {
+ if (_incomplete) {
+ return false;
+ }
+ if (_rpcRunning && !_encounterError) {
+ return !_promises.isEmpty();
Review Comment:
when the rpc compeleted, the scan is not compeleted, but the key-value is
cached on the _kvs and promise queues, obtained in turn through next(), and
_promises.removeFirst()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]