foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907964547
##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
DEPENDS boost
)
+# kerberos
+ExternalProject_Add(krb5
Review Comment:
> And, for the non-centos6 platforms, we'd better skip build the two
packages since we have installed the packages.
I think if one package has compatibility problem in different env, the best
solution is specify unified version(if we can find the version) in thirdparty,
but not use different version in different env.
So I think the two package actually should be included in thirdparty though
in centos7, unless one day we no longer support centos6
##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
DEPENDS boost
)
+# kerberos
+ExternalProject_Add(krb5
Review Comment:
> And, for the non-centos6 platforms, we'd better skip build the two
packages since we have installed the packages.
I think if one package has compatibility problem in different env, the best
solution is specify unified version(if we can find the version) in thirdparty,
but not use different version in different env.
So I think the two package actually should be included in thirdparty though
in centos7, unless one day we no longer support centos6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
