totalo commented on code in PR #1087:
URL: https://github.com/apache/incubator-pegasus/pull/1087#discussion_r936154844
##########
java-client/src/main/java/org/apache/pegasus/client/PegasusScanner.java:
##########
@@ -188,6 +193,16 @@ private void asyncStartScan() {
new Table.ClientOPCallback() {
@Override
public void onCompletion(client_operator clientOP) throws Throwable {
+ if (!(clientOP instanceof rrdb_get_scanner_operator)) {
+ logger.error(
+ "scan rpc callback, encounter logic error, we just abandon
this scan, "
+ + "tableName({}), appId({})",
+ _table.getTableName(),
Review Comment:
Yes, but in this project, many of the formats are C-grammatical formats, and
the current way of writing this is entirely because the attribute names are
like this. I want to handle them uniformly in subsequent PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
