GehaFearless commented on code in PR #1091:
URL: https://github.com/apache/incubator-pegasus/pull/1091#discussion_r938599524
##########
src/server/pegasus_server_impl.cpp:
##########
@@ -2316,24 +2332,28 @@
pegasus_server_impl::append_key_value_for_scan(std::vector<::dsn::apps::key_valu
return range_iteration_state::kFiltered;
}
}
- std::shared_ptr<char>
key_buf(::dsn::utils::make_shared_array<char>(raw_key.length()));
- ::memcpy(key_buf.get(), raw_key.data(), raw_key.length());
- kv.key.assign(std::move(key_buf), 0, raw_key.length());
+ if (fill_value) {
Review Comment:
`return range_iteration_state::kNormal` All branches use it, So I think it
is unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
