acelyc111 commented on code in PR #1091:
URL: https://github.com/apache/incubator-pegasus/pull/1091#discussion_r952110910
##########
src/client_lib/pegasus_client_impl.h:
##########
@@ -247,13 +247,21 @@ class pegasus_client_impl : public pegasus_client
static void init_error();
+ enum class async_scan_type : char
Review Comment:
Do not expose it to public in header, make it as a private of `class
pegasus_scanner_impl` is enough?
##########
src/client_lib/pegasus_client_impl.h:
##########
@@ -247,13 +247,21 @@ class pegasus_client_impl : public pegasus_client
static void init_error();
+ enum class async_scan_type : char
+ {
+ NORMAL,
+ COUNT_ONLY,
+ COUNT_ONLY_FINISHED
+ };
+
class pegasus_scanner_impl : public pegasus_scanner
{
public:
int next(std::string &hashkey,
std::string &sortkey,
std::string &value,
- internal_info *info = nullptr) override;
+ internal_info *info = nullptr,
+ int32_t *count = nullptr) override;
Review Comment:
hashkey-sortkey-value and count will not be returned at the same time? If
not, separete it into two functions would be better. one is:
```
int next(std::string &hashkey,
std::string &sortkey,
std::string &value,
internal_info *info = nullptr)
```
the other is
```
int next(int32_t &count,
internal_info *info = nullptr)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
