acelyc111 commented on code in PR #1149: URL: https://github.com/apache/incubator-pegasus/pull/1149#discussion_r964906027
########## src/test/function_test/utils/test_util.h: ########## @@ -0,0 +1,51 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, +* software distributed under the License is distributed on an +* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +* KIND, either express or implied. See the License for the +* specific language governing permissions and limitations +* under the License. +*/ + +#pragma once + +#include <memory> + +#include <gtest/gtest.h> + +namespace dsn { +namespace replication { +class replication_ddl_client; +} // namespace replication +} // namespace dsn + +namespace pegasus { +class pegasus_client; + +class test_util : public ::testing::Test +{ +public: + test_util(); + virtual ~test_util(); + + static void SetUpTestCase(); + + void SetUp() override; + +protected: + std::string cluster_name_; + std::string app_name_; + pegasus_client *client = nullptr; Review Comment: There is some controversy that whether the underscore is at the start or at the end, for the google code style guide for Cpp [1], it is at the end. For the new added files, we can keep it at the end, and when we plan to refactor old code, we can update them to the end. 1. https://google.github.io/styleguide/cppguide.html#Variable_Names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org For additional commands, e-mail: dev-h...@pegasus.apache.org
