empiredan commented on code in PR #1211:
URL:
https://github.com/apache/incubator-pegasus/pull/1211#discussion_r1007682089
##########
src/nfs/nfs_client_impl.cpp:
##########
@@ -449,9 +450,7 @@ void nfs_client_impl::continue_write()
std::string file_path =
dsn::utils::filesystem::path_combine(fc->user_req->file_size_req.dst_dir,
fc->file_name);
std::string path =
dsn::utils::filesystem::remove_file_name(file_path.c_str());
- if (!dsn::utils::filesystem::create_directory(path)) {
- dassert(false, "create directory %s failed", path.c_str());
- }
+ CHECK(dsn::utils::filesystem::create_directory(path), "create directory {}
failed");
Review Comment:
```suggestion
CHECK(dsn::utils::filesystem::create_directory(path), "create directory
{} failed", path);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
