empiredan commented on issue #1206: URL: https://github.com/apache/incubator-pegasus/issues/1206#issuecomment-1298191783
> Some questions: > > 1. In the response, I know the metrics will be filtered out, but will all the `type`, `id` and `attributes` (with all attribute k-v pairs) be returned no matter what the query string is ? > 2. Is it helpful to return the description of each metrics, such as `statistic the qps of PUT request` for "put_qps" ? We can add a more parameter to decide whether to return it, because it's verbos if return it every time. > 3. Metrics type (e.g. counter, guage, percentile) is same to point 2. Good questions ! I'll answer each as follows: 1. Yes, in current design, all of `type`, `id` and `attributes` with all k-v pairs will be returned. And I think returned fields of entities can be custom. 2. Yes, actually the description for metric has been a property of `metric_prototype`, and certainly can be a field returned. As is put in the answer for 1st question, to support custom fields, 2 parameters can be introduced: `with_entity_field` and `without_entity_field`. For example, `with_entity_field=type,desc` will only call for `type` and `desc` fields; and `without_entity_field=id,desc` will return all fields except `id` and `desc`, is this alright ? 3. As for metric, use `with_metric_field` and `without_metric_field`. For example, `with_metric_field=value,p99` means it will just return the `value` of gauge or counter, and `p99` of percentile, if any. 4. Just use the parameters in answer for 3rd question, percentile types can also be custom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
