acelyc111 commented on code in PR #1217:
URL:
https://github.com/apache/incubator-pegasus/pull/1217#discussion_r1013188631
##########
src/aio/disk_engine.cpp:
##########
@@ -107,7 +107,7 @@ aio_task *disk_file::write(aio_task *tsk, void *ctx)
aio_task *disk_file::on_read_completed(aio_task *wk, error_code err, size_t
size)
{
- dassert(wk->next == nullptr, "");
+ CHECK(wk->next == nullptr, "");
Review Comment:
As commented in fmt_logging.h, maybe we can introduce a new macro
`CHECK_NULL` for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
