empiredan opened a new issue, #1252:
URL: https://github.com/apache/incubator-pegasus/issues/1252

   ```c++
           CHECK_EQ_MSG(std::strcmp(prototype->name(), 
iter->second->prototype()->name()),
                        0,
                        "new prototype '{}' is inconsistent with old prototype 
'{}' for entity '{}'",
                        prototype->name(),
                        iter->second->prototype()->name(),
                        id);
   ```
   
   While asserting failed for the above code, I found the logging had shown as:
   
   ```
   F2022-11-23 14:01:47.885 (1669183307885368773 37956) : assertion expression: 
_v1 == _v2
   F2022-11-23 14:01:47.885 (1669183307885401886 37956) : 1 vs 0 new prototype 
'my_table' is inconsistent with old prototype 'my_server' for entity 'server_81'
   ```
   
   I think in the line of `assertion expression:` should be shown the true 
expression, for example:
   ```
   F2022-11-23 14:01:47.885 (1669183307885368773 37956) : assertion expression: 
std::strcmp(prototype->name(), iter->second->prototype()->name()) == 0
   F2022-11-23 14:01:47.885 (1669183307885401886 37956) : 1 vs 0 new prototype 
'my_table' is inconsistent with old prototype 'my_server' for entity 'server_81'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to