Apache9 commented on code in PR #1266: URL: https://github.com/apache/incubator-pegasus/pull/1266#discussion_r1034883205
########## java-client/configuration/log4j.properties: ########## @@ -1,42 +0,0 @@ -# Review Comment: In java world we use maven or gradle to download dependencies, usually a jar and its transitive dependencies, and the configuration file should be prepared by the end users, when setting up its own application which uses pegasus java client. And for running UTs, I moved the log4j.properties and pegasus.properties to src/test/resources. This is the default place for putting test resources, and you can load these fiels with getResourceAsStream when running UTs. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
