empiredan opened a new issue, #1299:
URL: https://github.com/apache/incubator-pegasus/issues/1299

   While asserting equality between two C strings now we have to check if 
`strcmp` returns 0, for example:
   
   ```c++
   CHECK_EQ_MSG(std::strcmp(prototype->name(), 
iter->second->prototype()->name()),
                0,
                "new prototype '{}' is inconsistent with old prototype '{}' for 
entity '{}'",
                prototype->name(),
                iter->second->prototype()->name(),
                id);
   ```
   
   We can support CHECK_STREQ* and CHECK_STRNE* in common macros for C strings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to