WHBANG commented on code in PR #1315:
URL:
https://github.com/apache/incubator-pegasus/pull/1315#discussion_r1073025939
##########
src/replica/replica_check.cpp:
##########
@@ -160,12 +158,12 @@ void replica::on_group_check(const group_check_request
&request,
if (request.config.ballot < get_ballot()) {
response.err = ERR_VERSION_OUTDATED;
- LOG_WARNING("%s: on_group_check reply %s", name(),
response.err.to_string());
+ LOG_WARNING_PREFIX("on_group_check reply {}", response.err);
Review Comment:
Thank you for your valuable comments
_ PREFIX can print _name of the class. class replica_check inherits class
replica, class replica inherits replica_base, and replica_base implements the
method of print _name, so there is no problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
