empiredan commented on code in PR #1351:
URL:
https://github.com/apache/incubator-pegasus/pull/1351#discussion_r1115282563
##########
src/server/pegasus_write_service.cpp:
##########
@@ -36,111 +124,36 @@
pegasus_write_service::pegasus_write_service(pegasus_server_impl *server)
_server(server),
_impl(new impl(server)),
_batch_start_time(0),
- _cu_calculator(server->_cu_calculator.get())
+ _cu_calculator(server->_cu_calculator.get()),
+ _put_counter(METRIC_put_requests.instantiate(replica_metric_entity())),
Review Comment:
Normally instantiations for all metric types will not lead to error. Once
instantiation fails, the process will crash which means there must have been
some bug. For example, the metric entity is uninitialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
