acelyc111 commented on code in PR #1378:
URL:
https://github.com/apache/incubator-pegasus/pull/1378#discussion_r1122558958
##########
src/common/json_helper.h:
##########
@@ -493,6 +494,26 @@ inline bool json_decode(const JsonObject &in, std::set<T>
&t)
return true;
}
+template <typename T1, typename T2>
Review Comment:
`typename T2` can be removed?
##########
src/common/json_helper.h:
##########
@@ -493,6 +494,26 @@ inline bool json_decode(const JsonObject &in, std::set<T>
&t)
return true;
}
+template <typename T1, typename T2>
+inline void json_encode(JsonWriter &out, const std::unordered_set<T1, T2> &t)
Review Comment:
Is it possiable to make std::unordered_set as a template type too? then it
can replace the template function above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
