WHBANG commented on code in PR #1378:
URL:
https://github.com/apache/incubator-pegasus/pull/1378#discussion_r1130966078
##########
src/runtime/ranger/ranger_resource_policy_manager.h:
##########
@@ -44,6 +64,11 @@ class ranger_resource_policy_manager
~ranger_resource_policy_manager() = default;
+private:
+ // Parse Ranger ACL policies from 'data' in JSON format into 'policies'.
+ static void parse_policies_from_json(const rapidjson::Value &data,
Review Comment:
This is what I did originally, but I found that it is not easy to write unit
test. After discussing with @acelyc111 , I changed it into a static member
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
