acelyc111 commented on code in PR #1402:
URL:
https://github.com/apache/incubator-pegasus/pull/1402#discussion_r1151334674
##########
src/runtime/ranger/ranger_resource_policy_manager.cpp:
##########
@@ -187,6 +199,73 @@
ranger_resource_policy_manager::ranger_resource_policy_manager(
_ac_type_of_database_rpcs);
}
+void ranger_resource_policy_manager::start()
+{
+ CHECK(_meta_svc != nullptr, "Pointer meta_svc cannot be null");
Review Comment:
The message can be infered so can be omitted?
```suggestion
CHECK_NOTNULL(_meta_svc, "");
```
##########
src/runtime/test/ranger_resource_policy_manager_test.cpp:
##########
@@ -256,5 +257,106 @@ TEST(ranger_resource_policy_manager_test,
get_table_name_from_app_name_test)
}
}
+class ranger_resource_policy_manager_function_test : public testing::Test
Review Comment:
How about:
```
class ranger_resource_policy_manager_test : public
ranger_resource_policy_manager, public testing::Test
```
Maybe define some members of ranger_resource_policy_manager as protected and
remove the friend declaration will work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
