acelyc111 commented on code in PR #1438:
URL:
https://github.com/apache/incubator-pegasus/pull/1438#discussion_r1167471590
##########
src/meta/meta_backup_service.cpp:
##########
@@ -830,12 +862,8 @@ void policy_context::start()
continue_current_backup_unlocked();
}
- std::string counter_name = _policy.policy_name +
".recent.backup.duration(ms)";
- _counter_policy_recent_backup_duration_ms.init_app_counter(
- "eon.meta.policy",
- counter_name.c_str(),
- COUNTER_TYPE_NUMBER,
- "policy recent backup duration time");
+ CHECK(!(_policy.policy_name.empty()), "policy_name should has been
initialized");
Review Comment:
```suggestion
CHECK(!_policy.policy_name.empty(), "policy_name should has been
initialized");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
