empiredan commented on code in PR #1447:
URL:
https://github.com/apache/incubator-pegasus/pull/1447#discussion_r1174557656
##########
src/runtime/serverlet.h:
##########
@@ -90,6 +90,8 @@ class rpc_replier
return _response != nullptr ? _response->to_address :
rpc_address::s_invalid_address;
}
+ int error_code() const { return _response != nullptr ? _response->error()
: 0; }
Review Comment:
For `rpc_replier`, the reason why we just need the error code in
`message_ex`, rather than field `error` in thrift object `TResponse`, is that
there is no read api (`on_get`, `on_multi_get`, ...) using `rpc_replier` to
reply ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
