empiredan commented on code in PR #1474: URL: https://github.com/apache/incubator-pegasus/pull/1474#discussion_r1191195347
########## src/replica/bulk_load/replica_bulk_loader.cpp: ########## @@ -50,6 +48,41 @@ #include "utils/string_view.h" #include "utils/thread_access_checker.h" +METRIC_DEFINE_counter(replica, + bulk_load_download_count, Review Comment: OK. Actually in perf counter they are accumulative counter. We could observe their increase. We could also change them to gauge, by decreasing them while finished. Is this OK ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
