acelyc111 commented on code in PR #1565:
URL:
https://github.com/apache/incubator-pegasus/pull/1565#discussion_r1283441714
##########
src/server/pegasus_manual_compact_service.h:
##########
@@ -91,7 +91,9 @@ class pegasus_manual_compact_service : public
dsn::replication::replica_base
// manual compact state
std::atomic<bool> _disabled;
+ std::atomic<bool> _time_natural_increase;
std::atomic<int> _max_concurrent_running_count;
+ std::atomic<uint64_t> _manual_compact_first_day_s;
Review Comment:
Could you please add some comments for the newly added variable?
The logic is too complex if adding these variables, if the current
"periodic", "max_concurrent_running" features are not well implemented, I don't
mind you to rewrite them or even remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
