acelyc111 commented on code in PR #1577:
URL:
https://github.com/apache/incubator-pegasus/pull/1577#discussion_r1285213580
##########
src/common/test/run.sh:
##########
@@ -31,6 +31,25 @@ exit_if_fail() {
fi
}
+if [ -n ${TEST_OPTS} ]; then
Review Comment:
I‘m planning to remove the `run.sh` scripts for unit tests in a long term,
this change may be a small block for that.
How about define the default value as
```
DSN_DEFINE_int32(replication,
disk_min_available_space_ratio,
#ifdef PEGASUS_UNIT_TEST
5,
#else
10,
#endif
"if disk available space ratio "
```
##########
src/common/test/run.sh:
##########
@@ -31,6 +31,25 @@ exit_if_fail() {
fi
}
+if [ -n ${TEST_OPTS} ]; then
Review Comment:
I‘m planning to remove the `run.sh` scripts for unit tests in a long term,
this change may be a small block for that.
How about define the default value as
```
DSN_DEFINE_int32(replication,
disk_min_available_space_ratio,
#ifdef PEGASUS_UNIT_TEST
5,
#else
10,
#endif
"if disk available space ratio "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
