empiredan commented on code in PR #1687:
URL:
https://github.com/apache/incubator-pegasus/pull/1687#discussion_r1401454789
##########
.licenserc.yaml:
##########
@@ -69,9 +69,9 @@ header:
- 'thirdparty/fix_jemalloc_for_m1_on_macos.patch'
- 'thirdparty/fix_libevent_for_macos.patch'
- 'thirdparty/fix_prometheus-cpp_limits.patch'
+ - 'thirdparty/fix_rocksdb-cmake-PORTABLE-option.patch'
- 'thirdparty/fix_s2_for_aarch64.patch'
- 'thirdparty/fix_thrift_for_cpp11.patch'
- - 'thirdparty/rocksdb_fix_atomic_flush_0879c240.patch'
Review Comment:
OK, could we just remove it in this PR ? `Check License` also said that
`thirdparty/rocksdb_fix_atomic_flush_0879c240.patch` should be removed once
it's not in `.licenserc.yaml`:
```
INFO Loading configuration from file: .licenserc.yaml
INFO Totally checked 1705 files, valid: 1065, invalid: 1, ignored: 639,
fixed: 0
ERROR the following files don't have a valid license header:
thirdparty/rocksdb_fix_atomic_flush_0879c240.patch
ERROR one or more files does not have a valid license header
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
