empiredan commented on code in PR #1808:
URL:
https://github.com/apache/incubator-pegasus/pull/1808#discussion_r1435845642
##########
src/runtime/security/negotiation.cpp:
##########
@@ -40,6 +37,8 @@ DSN_DEFINE_bool(security,
DSN_DEFINE_bool(security, mandatory_auth, false, "wheter to do authertication
mandatorily");
DSN_TAG_VARIABLE(mandatory_auth, FT_MUTABLE);
+const std::set<std::string> negotiation::supported_mechanisms{"GSSAPI"};
Review Comment:
```suggestion
const std::set<std::string> negotiation::kSupportedMechanisms{"GSSAPI"};
```
##########
src/runtime/security/negotiation.h:
##########
@@ -54,6 +55,10 @@ class negotiation
bool check_status(negotiation_status::type status,
negotiation_status::type expected_status);
protected:
+ // TODO(zlw):we can't get string list from cflags now,
+ // so we should get supported mechanisms from config in the later
+ static const std::set<std::string> supported_mechanisms;
Review Comment:
```suggestion
static const std::set<std::string> kSupportedMechanisms;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
