empiredan commented on code in PR #1825:
URL:
https://github.com/apache/incubator-pegasus/pull/1825#discussion_r1441493401
##########
src/runtime/test/host_port_test.cpp:
##########
@@ -114,6 +118,15 @@ TEST(host_port_test, rpc_group_host_port)
rpc_group_host_port *g = hp_grp.group_host_port();
ASSERT_EQ(std::string("test_group"), g->name());
+ host_port hp_grp1;
+ hp_grp1.assign_group("test_group");
+ if (reinterpret_cast<uint64_t>(hp_grp.group_host_port()) <
+ reinterpret_cast<uint64_t>(hp_grp1.group_host_port())) {
+ ASSERT_TRUE(hp_grp < hp_grp1);
Review Comment:
```suggestion
ASSERT_LT(hp_grp, hp_grp1);
```
##########
src/runtime/test/host_port_test.cpp:
##########
@@ -114,6 +118,15 @@ TEST(host_port_test, rpc_group_host_port)
rpc_group_host_port *g = hp_grp.group_host_port();
ASSERT_EQ(std::string("test_group"), g->name());
+ host_port hp_grp1;
+ hp_grp1.assign_group("test_group");
+ if (reinterpret_cast<uint64_t>(hp_grp.group_host_port()) <
+ reinterpret_cast<uint64_t>(hp_grp1.group_host_port())) {
+ ASSERT_TRUE(hp_grp < hp_grp1);
+ } else {
+ ASSERT_FALSE(hp_grp < hp_grp1);
Review Comment:
```suggestion
ASSERT_GE(hp_grp, hp_grp1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
