GehaFearless commented on code in PR #1825:
URL:
https://github.com/apache/incubator-pegasus/pull/1825#discussion_r1445701797
##########
src/runtime/rpc/rpc_host_port.h:
##########
@@ -118,6 +130,22 @@ inline bool operator==(const host_port &hp1, const
host_port &hp2)
inline bool operator!=(const host_port &hp1, const host_port &hp2) { return
!(hp1 == hp2); }
+inline bool operator<(const host_port &hp1, const host_port &hp2)
+{
+ if (hp1.type() != hp2.type()) {
+ return hp1.type() < hp2.type();
+ }
+
+ switch (hp1.type()) {
+ case HOST_TYPE_IPV4:
+ return hp1.host() < hp2.host() || (hp1.host() == hp2.host() &&
hp1.port() < hp2.port());
+ case HOST_TYPE_GROUP:
+ return reinterpret_cast<uint64_t>(hp1.group_host_port().get()) <
+ reinterpret_cast<uint64_t>(hp2.group_host_port().get());
Review Comment:
I think it's better to be specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
