acelyc111 commented on code in PR #1841:
URL:
https://github.com/apache/incubator-pegasus/pull/1841#discussion_r1445771358
##########
src/server/pegasus_mutation_duplicator.h:
##########
@@ -91,6 +91,13 @@ class pegasus_mutation_duplicator : public
dsn::replication::mutation_duplicator
METRIC_VAR_DECLARE_counter(dup_shipped_successful_requests);
METRIC_VAR_DECLARE_counter(dup_shipped_failed_requests);
+
+ uint64_t _dup_max_allowed_write_size =
dsn_config_get_value_uint64("replication",
Review Comment:
It's recommend to use the gflag style to load config, for example:
```
DSN_DEFINE_uint32(replication,
duplicate_log_batch_bytes,
4096,
"send mutation log batch bytes size per rpc");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
