empiredan commented on code in PR #1839:
URL:
https://github.com/apache/incubator-pegasus/pull/1839#discussion_r1447290923
##########
src/test/function_test/utils/test_util.h:
##########
@@ -49,7 +49,8 @@ class pegasus_client;
class test_util : public ::testing::Test
{
public:
- test_util(std::map<std::string, std::string> create_envs = {});
+ test_util(std::map<std::string, std::string> create_envs = {},
+ std::string cluster_name = "onebox");
Review Comment:
```suggestion
const std::string &cluster_name = "onebox");
```
##########
src/test/function_test/utils/test_util.cpp:
##########
@@ -62,12 +62,12 @@ using std::vector;
namespace pegasus {
-test_util::test_util(map<string, string> create_envs)
+test_util::test_util(map<string, string> create_envs, std::string cluster_name)
Review Comment:
```suggestion
test_util::test_util(map<string, string> create_envs, const std::string
&cluster_name)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
